Skip to content

Conversation

naomi-lgbt
Copy link
Member

@naomi-lgbt naomi-lgbt commented Aug 4, 2025

Checklist:

Closes #556
Replaces #942

List of TypeScript concepts taught

  • Type Annotations
  • Generic Functions
  • Interfaces
  • enums
  • type assertions
  • DOM types
  • type narrowing
  • type safety and error handling

Copy link

socket-security bot commented Aug 13, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License

View full report

@naomi-lgbt naomi-lgbt marked this pull request as ready for review August 27, 2025 21:19
@shootermv
Copy link
Contributor

shootermv commented Aug 31, 2025

thinking about improving the graphic design little bit...
image
i mean - the background color of header is different from body...

@jdwilkin4
Copy link
Contributor

@shootermv

thinking about improving the graphic design little bit...

I vote we leave it is as is. We don't want to spend to much time working in the wrong areas. Our time now should be shifting to teaching this project 👍🏾

The current styles look good and clean. So we should stick with that

Copy link
Contributor

@jdwilkin4 jdwilkin4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left two small comments otherwise, this should be good to go. 👍🏾

@jdwilkin4 jdwilkin4 merged commit de986e6 into freeCodeCamp:main Sep 2, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: create typescript fortune telling app workshop
6 participants