-
-
Notifications
You must be signed in to change notification settings - Fork 111
feat: add flashcard app workshop #949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
…pescript-sprint into feat/flashcard-app
…pescript-sprint into feat/flashcard-app
Complete the flashcard quiz app with a cleaner UI and control panel to make it look like an actual app. |
…pescript-sprint into feat/flashcard-app
i think it can be better to convert all the separate methods (like |
Co-authored-by: Naomi <[email protected]>
This comment was marked as resolved.
This comment was marked as resolved.
i have ui suggestion: to move |
children that must be buttons. The `isButtonElement` function was implemented, but unused.
was flipped. This is likely specific to certain browsers (firefox, zen). The resolution was simply to give the front of the card a specific rotation transform so the browser can determine which orientations should hide the front card.
testing the type guard. - Ran linter.
…iz-app Feedback bugfixes/flashcard quiz app
Sure. |
one more question: do we need |
It's hard to beat back and front semantically. It immediately tells me that there is a back and front face for this css, and explains why there are properties like If we do see a benefit in question and answer, I would prefer those be added to the text that the front and back of the cards contain, rather than the card faces themselves, or even as an additional class to the cards. |
it can be better to move all the methods to be a class-member methods instead |
@shootermv Why did you remove the keydown handler? |
i removed it since it wasnt doing noting (i suppose the initial intention was - to flip the card when user presses enter, which looks not so correct to me) |
fullstack-cert/typescript-projects/flashcard-quiz-app/src/script.ts
Outdated
Show resolved
Hide resolved
fullstack-cert/typescript-projects/flashcard-quiz-app/src/script.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Naomi <[email protected]>
im little concerned by the fact that there is some methods class based and others - not... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏾
Checklist:
Update index.md
)Closes #644
Replaces #933
List of TypeScript Concepts taught