Skip to content

Conversation

naomi-lgbt
Copy link
Member

@naomi-lgbt naomi-lgbt commented Aug 4, 2025

Checklist:

Closes #644
Replaces #933

List of TypeScript Concepts taught

  • Type Annotations
  • Interfaces
  • Type Guards
  • Generic DOM Typing
  • Union & Type Narrowing
  • Type-safe error handling
  • Typed Events

Copy link

socket-security bot commented Aug 4, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Added@​parcel/​transformer-typescript-tsc@​2.15.4991006290100
Added@​parcel/​config-default@​2.15.4981006286100
Addedparcel@​2.15.4981009086100
Addedprettier@​3.6.29910010089100

View full report

@eastbetsy
Copy link
Contributor

Complete the flashcard quiz app with a cleaner UI and control panel to make it look like an actual app.
Credits to Musa for the Typescript. I just fixed it a bit when I edited the HTML and CSS for the new UI.
Not sure what to do for the quiz part. I hope this passes for now. Let me know if anything needs fixed. Sorry for the inactivity!

@shootermv
Copy link
Contributor

shootermv commented Aug 18, 2025

i think it can be better to convert all the separate methods (like refresh or flipcard), the code has currently - to private methods of FlashCardGame class...
it will more typescript-style

@a2937

This comment was marked as resolved.

@shootermv
Copy link
Contributor

shootermv commented Aug 24, 2025

i have ui suggestion: to move flip button to be below the card
and rename the right section to manage cards, like here:
image
Also instead of back & front - will it be better to change it to question & answer?
what do you think? @ElectricMolasses @a2937 ?

ElectricMolasses and others added 5 commits August 24, 2025 15:48
  children that must be buttons. The `isButtonElement` function was
  implemented, but unused.
  was flipped. This is likely specific to certain browsers (firefox,
  zen). The resolution was simply to give the front of the card a
  specific rotation transform so the browser can determine which
  orientations should hide the front card.
…iz-app

Feedback bugfixes/flashcard quiz app
@a2937
Copy link
Member

a2937 commented Aug 24, 2025

Sure.

@shootermv
Copy link
Contributor

shootermv commented Aug 25, 2025

one more question: do we need typescript package listed in the package.json list?
currently it is missing

@ElectricMolasses
Copy link
Contributor

ElectricMolasses commented Aug 25, 2025

i have ui suggestion: to move flip button to be below the card and rename the right section to manage cards, like here: image Also instead of back & front - will it be better to change it to question & answer? what do you think? @ElectricMolasses @a2937 ?

It's hard to beat back and front semantically. It immediately tells me that there is a back and front face for this css, and explains why there are properties like RotateY. question and answer describes none of the implementation to me, only what the text is going to represent.

If we do see a benefit in question and answer, I would prefer those be added to the text that the front and back of the cards contain, rather than the card faces themselves, or even as an additional class to the cards. .front and .back shouldn't be removed/replaced.

@shootermv
Copy link
Contributor

it can be better to move all the methods to be a class-member methods instead

@a2937
Copy link
Member

a2937 commented Aug 27, 2025

@shootermv Why did you remove the keydown handler?

@shootermv
Copy link
Contributor

shootermv commented Aug 27, 2025

@shootermv Why did you remove the keydown handler?

i removed it since it wasnt doing noting (i suppose the initial intention was - to flip the card when user presses enter, which looks not so correct to me)

@naomi-lgbt naomi-lgbt marked this pull request as ready for review August 27, 2025 23:11
@shootermv
Copy link
Contributor

im little concerned by the fact that there is some methods class based and others - not...

Copy link
Contributor

@jdwilkin4 jdwilkin4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏾

@jdwilkin4 jdwilkin4 merged commit b608cd2 into freeCodeCamp:main Sep 2, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: create typescript flashcard quiz workshop
6 participants