fix: crash on macOS #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most of it replaced by winit
Basically release with debug symbols
This optimizes the scrolling a bit, especially pure up/down.
This currently disables smooth scrolling. Which will be re-implemented using the scroll events and the skia pictures instead of the old scrolling snapshots.
This also optimizes the blurring step, to not be done unless needed. Also removes the neovide_floating_opacity setting, since it's not clear how that should interact with neovim's default way of dealing with transparncy.
All events are now processed before allowing rendering. All attempts to limit the frame rate is also removed temporarily.
The idea is to have the update phase determine if rendering is needed. But currently that's not dealt with correctly.
This properly submits everything to the GPU
Formatting Split: Also includes color fixes, for example Hack for the position I think the size is broken, since the statusline is not as tall as it should be.
This should be done properly, and we should be able to turn it off
Still with a lot of problems, the most obvious one is that the scaling and positioning of the glyphs are wrong. The atlas box should not scale to the whole rendering box.
This comment was marked as outdated.
This comment was marked as outdated.
qinyuhang
force-pushed
the
wgpu
branch
2 times, most recently
from
32004fb to
656bbf4
Compare
This comment was marked as outdated.
This comment was marked as outdated.
The crash log: 'called `Option::unwrap()` on a `None` value'. (File: src/renderer/renderer.rs; Line: 109, Column: 18) It is mainly because call DX12 on all platform. After change to conditional choose GPU, macOS require get METAL in UI thread KNOWN ISSUE: the window is transparent in macOS, only the titlebar is presented
|
I think the main reason of the empty window body could be reuse of render_pass. Maybe instead of reuse one |
fredizzimo
force-pushed
the
fsundvik/wgpu
branch
from
b630b64 to
428f16d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Detail
When
cargo runon macOS, the neovide crashed with crash log:It is mainly because call DX12 on all platform.
After change to conditional choose GPU, macOS require get METAL in UI thread
KNOWN ISSUE: the window is transparent in macOS, only the titlebar is presented
Did this PR introduce a breaking change?
A breaking change includes anything that breaks backwards compatibility either at compile or run time.