Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update XeroUnauthorized to handle json response #337

Merged
merged 10 commits into from
Sep 30, 2023

Conversation

schapman1974
Copy link
Contributor

Added json handling to XeroUnauthorized for response on a 401 status that looks like this
{"Type":null,"Title":"Unauthorized","Status":401,"Detail":"TokenExpired: token expired at 04/09/2023 05:16:59","Instance":"6489df60-8891-470e-9268-a9a43f5da71e","Extensions":{}}
The Exception itself was erroring so it was falling through to a normal Exception

Added json handling to XeroUnauthorized for response on a 401 status that looks like this
{"Type":null,"Title":"Unauthorized","Status":401,"Detail":"TokenExpired: token expired at 04/09/2023 05:16:59","Instance":"6489df60-8891-470e-9268-a9a43f5da71e","Extensions":{}}
The Exception itself was erroring so it was falling through to a normal Exception
@freakboy3742 freakboy3742 marked this pull request as ready for review September 30, 2023 02:09
Copy link
Owner

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made a couple of tweaks - not least of all is getting the tests to pass - but this was a solid starting point for me to work from. Thanks for the PR (and apologies for the delayed review)!

@freakboy3742 freakboy3742 merged commit c306ca7 into freakboy3742:main Sep 30, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants