-
Notifications
You must be signed in to change notification settings - Fork 569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: SCORM Course Resume Functionality #1263
Draft
FahidLatheef
wants to merge
6
commits into
frappe:develop
Choose a base branch
from
FahidLatheef:feat/scorm-progress
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lms
|
Project |
lms
|
Branch Review |
feat/scorm-progress
|
Run status |
|
Run duration | 00m 29s |
Commit |
|
Committer | Fahid Latheef A |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
0
|
|
0
|
|
0
|
|
0
|
|
1
|
Upgrade your plan to view test results. | |
View all changes introduced in this branch ↗︎ |
831da9c
to
ccd43f6
Compare
…ng SCORM Data Model feat: added is_scorm_chapter and scorm_content to track cmi.suspend_data for resuming scorm chapter
- Replaced already_completed with progress_already_exists variable - Added scorm_details parameter to save_progress whitelisted function - Added Separate logic for SCORM chapter progress in save_progress
…hether to allow retake of final quiz or Reset the whole Course)
3543013
to
2ce2df6
Compare
@FahidLatheef can you please add a video showing how Partially Complete status is working in context to the changes made in this PR |
75f3b3a
to
2ce2df6
Compare
Converting this to Draft, I need to change statistics calculation based on LMS Course Progress |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR Includes
SCORM Progress
is_scorm_chapter
andscorm_content
to LMS Course Progress for SCORM Lessons.scorm_content
is updated whenever SCORM Data modelcmi.suspend_data
is triggered. Moreover, fieldstatus
is upserted with value 'Partially Complete'.scorm_content
is set in bothcmi.suspend_data
andcmi.launch_data
.scorm_content
field is emptied.Style Changes
Closes #1262
Future TODOs
cmi.suspend_data
can become long, we can compress the same for better storage performances.cmi.core.lesson_location
Data Model to track progress, we may use them for tracking progress