Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Formula-based Final Score calculation in Appraisals #1670

Merged
merged 12 commits into from
May 29, 2024
Merged

feat: Formula-based Final Score calculation in Appraisals #1670

merged 12 commits into from
May 29, 2024

Commits on Apr 23, 2024

  1. feat: allow adding formula to calculate final score in appraisal cycle

    @vinyselopal
    vinyselopal committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    1712990 View commit details
    Browse the repository at this point in the history

  2. refactor: PR review changes

    @vinyselopal
    vinyselopal committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    dc6610a View commit details
    Browse the repository at this point in the history

  3. refactor: function placement in appraisal_cycle.py

    @vinyselopal
    vinyselopal committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    cc42051 View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2024

  1. refactor: separate logic for test_appraisal_using_formula from create… 

    …_appraisal
    @vinyselopal
    vinyselopal committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    bfb2d8c View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2024

  1. refactor: triggering form event

    @vinyselopal
    vinyselopal committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    546d5e2 View commit details
    Browse the repository at this point in the history

Commits on May 29, 2024

  1. fix(test): revert final score changes

    @ruchamahabal
    ruchamahabal committed May 29, 2024
    Configuration menu
    Copy the full SHA
    02fc26d View commit details
    Browse the repository at this point in the history

  2. fix: adjust score for autocompletions

    @ruchamahabal
    ruchamahabal committed May 29, 2024
    Configuration menu
    Copy the full SHA
    401d2f0 View commit details
    Browse the repository at this point in the history

  3. fix: formula checkbox label

    @ruchamahabal
    ruchamahabal committed May 29, 2024
    Configuration menu
    Copy the full SHA
    3a8091d View commit details
    Browse the repository at this point in the history

  4. fix: goal score autocompletion

    @ruchamahabal
    ruchamahabal committed May 29, 2024
    Configuration menu
    Copy the full SHA
    969c2e8 View commit details
    Browse the repository at this point in the history

  5. refactor: calculate_final_score function 

    - remove unnecessary conditions

- get cached doc for formula eval

- rearrange related code blocks together
    @ruchamahabal
    ruchamahabal committed May 29, 2024
    Configuration menu
    Copy the full SHA
    a2c2a8c View commit details
    Browse the repository at this point in the history

  6. refactor(UX): avoid 2 primary btns in appraisal cycle form

    @ruchamahabal
    ruchamahabal committed May 29, 2024
    Configuration menu
    Copy the full SHA
    af93aed View commit details
    Browse the repository at this point in the history

  7. feat: set desc for formula setting & make formula mandatory if checkb… 

    …ox is enabled
    @ruchamahabal
    ruchamahabal committed May 29, 2024
    Configuration menu
    Copy the full SHA
    70e30c7 View commit details
    Browse the repository at this point in the history