Skip to content

Conversation

@bvisible
Copy link
Contributor

@bvisible bvisible commented Jan 1, 2026

Summary

Components translated:

  • Settings components: Canned responses, Email settings, SLA, Teams, Holidays, etc.
  • Modal components: MergeCategoryModal, TicketSplitModal, CustomerDialog, CallLogDetailModal, etc.
  • Page components: Contacts, Customers, CallLogs, Articles, KnowledgeBase, Ticket pages
  • Utility components: Autocomplete, EmptyState, CommunicationArea, TextEditor, EmailEditor
  • Ticket components: TicketAgentActivities, TicketAgentDetails, TicketAgentFields, TicketBreadcrumbs
  • View controls: Filter.vue (operators, timespan options), SortBy.vue
  • Telephony: CallUI, TwilioCallUI, ExotelCallUI

Translation pattern used:

import { __ } from "@/translation";

// Simple strings
__("Filter")

// String interpolation
__("{0} matches", [count])
__("Due in {0}", [formatTime(seconds)])

Test plan

  • Build passes without errors (yarn build)
  • Verify translations work correctly with a non-English locale
  • Check that interpolated strings display correctly

@codecov
Copy link

codecov bot commented Jan 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 39.64%. Comparing base (819c28a) to head (610b3c6).
⚠️ Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2856      +/-   ##
===========================================
- Coverage    39.66%   39.64%   -0.03%     
===========================================
  Files          121      121              
  Lines         4924     4924              
===========================================
- Hits          1953     1952       -1     
- Misses        2971     2972       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

- Assignment Rules: Added __ import and translated ticketRoutingOptions
- EmailNotifications: Added __ import to Notification.vue
- FieldDependency: Translated all user-facing strings in criteria,
  fields selection, and value selection components
- Holiday: Full translation of calendar, list, table view, modals,
  and recurring holidays components

This is part of the effort to add i18n support across the codebase
as requested in PR frappe#2836.
- SLA: Translated all modals (EditResponseResolution, WorkDay),
  list items, priorities, status, workdays, and assignment conditions
- Agents: Translated role labels, dropdown options, toast messages
- AgentCard: Translated inactive badge
- Email: Translated config fields, labels, descriptions, validation
  messages, and service info texts
- InviteAgents: Translated role labels, toast messages
- EmailAccountList: Added __ import
- General: Added __ import to LogoUpload and WorkflowKnowledgebaseSettings
- Teams: Translated validation messages in NewTeam, button labels in
  TeamEdit and RenameTeamModal
- AssignmentModal: Translated title and placeholder
- ConfirmDialog: Translated confirm button label
- ViewModal: Translated title, placeholder, and button labels
- TicketMergeModal: Translated all strings and messages
- TicketSplitModal: Translated all strings and messages
- CategoryModal: Translated title and action button labels
- NewCustomerDialog: Translated title, labels, and messages
- MergeCategoryModal.vue
- MoveToCategoryModal.vue
- TicketSubjectModal.vue
- AddNewAgentsDialog.vue
- CustomerDialog.vue
- CallLogDetailModal.vue
- SettingsModal.vue (add missing import)
- InvalidPage.vue
- Contacts.vue
- Customers.vue
- CallLogs.vue
- Articles.vue
- KnowledgeBaseCustomer.vue
- TicketConversation.vue
- TicketAgent.vue
- TicketCustomerTemplateFields.vue
- TicketTextEditor.vue
- TicketBreadcrumbs.vue
- Autocomplete.vue
- EmptyState.vue
- CommunicationArea.vue
- TextEditor.vue
- EmailEditor.vue
@bvisible bvisible force-pushed the feat/i18n-vue-translations branch from d39943b to 848eec1 Compare January 1, 2026 16:22
@bvisible bvisible force-pushed the feat/i18n-vue-translations branch from 848eec1 to 610b3c6 Compare January 1, 2026 16:31
@RitvikSardana
Copy link
Member

@bvisible

are you using AI for it?

if yes can you share the prompt?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants