Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: address autocomplete dialog #26395

Draft
wants to merge 13 commits into
base: develop
Choose a base branch
from

Conversation

barredterra
Copy link
Collaborator

@barredterra barredterra commented May 9, 2024

Bildschirmfoto 2024-05-09 um 22 12 57

address_autocomplete.mov

Providers:

  • Geoapify,
  • Nomatim,
  • HERE?

Todo:

  • add something like a spinner to show active search
  • add a "No results" message
  • handle edge cases (i.e. click buttons with no result selected)
  • add documentation
    Note: Nomatim must be self-hosted. Using the public service for autocompletion is not allowed.

@barredterra barredterra added squash add-docs New feature should be have an entry in documentation to increase the discoverability labels May 9, 2024
@batonac
Copy link
Contributor

batonac commented May 17, 2024

Hey @barredterra, nice work here! I've done some work with geolocation integrations in my Customer Information System Enhancements for ERPNext app. I appreciate the concept of pushing more geolocation integrations upstream, and would be glad to pitch in if possible.

In thinking along these lines, perhaps it would be fitting to name your new settings Doctype "Geolocation Settings" instead of "Address Autocomplete Settings", with the goal of integrating providers for address geocoding as well as autocomplete.

@barredterra
Copy link
Collaborator Author

@batonac since Geoapify also offers these other Geolocation features, which could be easily added to our integration, I think your proposal makes sense. I'm not sure about other providers. Maybe at some point it will make more sense to have one settings page per provider.

@DrZoidberg09
Copy link
Contributor

Nice to see this in Frappe Framework. I have both features running in a private app using HERE Map services. Happy to contribute, if you are interested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add-docs New feature should be have an entry in documentation to increase the discoverability squash
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants