Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(TextEditor): Show editable rich editor in grid row #26366

Merged
merged 1 commit into from May 13, 2024
Merged

fix(TextEditor): Show editable rich editor in grid row #26366

merged 1 commit into from May 13, 2024

Conversation

cogk
Copy link
Contributor

@cogk cogk commented May 7, 2024

Before

image

After

image

frappe/frappe/public/js/frappe/form/grid_row.js

Lines 1103 to 1107 in 5009926

// no text editor in grid
if (df.fieldtype == "Text Editor") {
df = Object.assign({}, df);
df.fieldtype = "Text";
}

@cogk cogk requested a review from a team as a code owner May 7, 2024 12:44
@cogk cogk requested review from akhilnarang and removed request for a team May 7, 2024 12:44
@ankush ankush added the defer backport Backports for some PR are deferred for a week or two to test them properly before releasing label May 13, 2024
@ankush ankush merged commit 016e41c into frappe:develop May 13, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akhilnarang akhilnarang Awaiting requested review from akhilnarang akhilnarang was automatically assigned from frappe/frappe-review-team

Assignees
No one assigned
Labels
defer backport Backports for some PR are deferred for a week or two to test them properly before releasing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cogk @ankush