refactor: validate due date code and message according to doctype #45126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamejaaz
requested review from
ruthra-kumar and
rohitwaghchaure
as code owners
github-actions
bot
added
accounts
needs-tests
nabinhait
requested changes
Jan 7, 2025
Comment on lines
678
to
690
| validate_due_date( | ||
| posting_date, | ||
| self.due_date, | ||
| self.payment_terms_template, | ||
| posting_date=posting_date, | ||
| due_date=self.due_date, | ||
| template_name=self.payment_terms_template, | ||
| doctype=self.doctype, | ||
| ) | ||
| elif self.doctype == "Purchase Invoice": | ||
| validate_due_date( | ||
| posting_date, | ||
| self.due_date, | ||
| self.bill_date, | ||
| self.payment_terms_template, | ||
| posting_date=posting_date, | ||
| due_date=self.due_date, | ||
| bill_date=self.bill_date, | ||
| template_name=self.payment_terms_template, | ||
| doctype=self.doctype, |
There was a problem hiding this comment.
There is no need to call the function separately for sales and Purchase Invoices. Commonify them; only due_date is different in both cases.
There was a problem hiding this comment.
Hi @nabinhait ,
I have removed the redundant mandatory error validation. Could you please check again now?
nabinhait
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #44998
Sales Invoice
Purchase Invoice
