New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: remove redundant title field from sales transactions #45115

Open

barredterra wants to merge 1 commit into frappe:develop from barredterra:remove-title-field

Collaborator

barredterra commented Jan 6, 2025 •

edited

Loading

The title field in sales transactions was always set to customer_name. This means duplicate data and less descriptive column names.

Before:

DocType's title_field: title
Document's title: copied from customer_name
Document's customer_name: fetched from linked Customer

After:

DocType's title_field: customer_name
Document's customer_name: fetched from linked Customer

I've searched the codebase for .title = and \.title\n without relevant results.


          refactor!: remove redundant title field from sales transactions

a369a8d

barredterra requested review from ruthra-kumar and rohitwaghchaure as code owners

January 6, 2025 20:11

github-actions bot added the needs-tests label

barredterra added do not backport and removed needs-tests labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do not backport