Add table ovh_log_self #41
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makefile
Outdated
There was a problem hiding this comment.
Hi, could you clean the Makefile?
ovh/plugin.go
Outdated
| @@ -17,6 +17,7 @@ func Plugin(ctx context.Context) *plugin.Plugin { | |||
| }, | |||
| TableMap: map[string]*plugin.Table{ | |||
| "ovh_bill": tableOvhBill(), | |||
| "ovh_log_self": tableOvhLog(), | |||
|
Hi, Thanks for your contribution. I'll test it later. |
| select | ||
| id, | ||
| date, | ||
| acount |
There was a problem hiding this comment.
Suggested change
| acount | |
| account |
|
Hi, I tested it, works fine, good job. Once you fix the typo in the doc I'll merge and release a new version. |
|
Merged in ad3573f. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for a ovh_log_self table.
It fetches logs for previous API calls made in OVH Public Cloud API with one's own account, using this endpoint.