Skip to content

Commit

Permalink
get_maintainer: repair STDIN usage
Browse files Browse the repository at this point in the history
Commit 22dd5b0 (fix perlcritic warnings)
broke the ability to handle STDIN because the three argument version of
open() cannot handle standard IO-streams (which is mentioned in
PerlBestPractices, too).

Signed-off-by: Wolfram Sang <[email protected]>
Cc: Stephen Hemminger <[email protected]>
Acked-by: Joe Perches <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
  • Loading branch information
Wolfram Sang authored and torvalds committed Mar 24, 2010
1 parent 1d53661 commit 3a4df13
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion scripts/get_maintainer.pl
Original file line number Diff line number Diff line change
Expand Up @@ -284,7 +284,7 @@
my $file_cnt = @files;
my $lastfile;

open(my $patch, '<', $file)
open(my $patch, "< $file")
or die "$P: Can't open $file: $!\n";
while (<$patch>) {
my $patch_line = $_;
Expand Down

0 comments on commit 3a4df13

Please sign in to comment.