Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepended $VMDIR to all image paths for consistency #325

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lmlsna
Copy link

@lmlsna lmlsna commented Oct 2, 2020

There is a $VMDIR variable that defaults to "$PWD" and defines the base directory for the $OVMF. The BaseSystem and ESP partitons have no prefix however, so 2 of the 4 paths are getting $PWD included explicitly and the other two assume it implicitly. This will break if $VMDIR is defined as a different directory then the project root, or if the script is run from outside the project root.

I just prepended $VMDIR to those paths as well be consistent if $VMDIR is redefined.

Also:
It might be safer to use $(dirname $0) instead of $PWD as a default, since what we probably want is "the same directory as where this script is" and not necessarily "the directory the user ran this from." But I didn't change that in this pull request.

@lmlsna
Copy link
Author

lmlsna commented Oct 3, 2020

This looks duplicative with #327

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant