-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3339711 Add POTS to Sous #89
base: main
Are you sure you want to change the base?
Conversation
Work well for me! 👍🏾 maybe @ccjjmartin can confirm if it is what is needed |
…to issue-3339711--add-project-ci
Ideally, this PR would be associated with a site on Pantheon and the Project CI setup would include the necessary files to have CircleCI running the deployment. This does assume we are going to support Pantheon out of the box though so let's discuss this in the next Sous meeting @robert-arias |
@robert-arias @ccjjmartin This PR is marked "Needs Review" on d.o Do you know where we left off with this? |
It would be good to get this set up to deploy to a demo site on Pantheon. As part of this ticket, let's follow the steps here to create a sous project on Pantheon and configure this repo to deploy to it. |
@laura-johnson @ccjjmartin I set up a Pantheon site but as I started the process to migrate our repo to Pantheon I got stuck with understanding what we need to do with the web directory. Here is a thread on Slack of my confusion. |
CHANGELOG.md
Outdated
|
||
All notable changes specific to pantheon-upstreams/drupal-composer-managed are noted here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is the sous changelog overwritten with drupal-composer-managed changelog?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@laura-johnson Could it be a change from when @cbfannin merge the Pantheon repository with ours?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could be! I think we want the sous version though...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@laura-johnson @randallquesadaa Original changelog restored. Does that make this ready to merge? i.e. someone has functionally tested this?
Issue:
Project CIPOTS to SousDescription:
project ciPOTS to Sous and minimum requirements so a new build only needs to configure their ssh keys, tokens, etc on their deployment environments.Testing:
composer install
and make sureproject ciPOTS is installed.Notes
/web
directory andcomposer.lock
file. We decided this was not the best idea because we do not want to track these things in our repo.pantheon.yml
gets scaffolded only if it is a Pantheon site. This PR doesn't include this functionality but does include thepantheon.yml
file with settings that match Sous.lint
composer command and added alint.sh
script file to avoid linting errors since POTS will expect something here.code-sniff
command straight to phpcs and phpcbf without the added args and options. We can always improve on this but at least it runs now.