Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3339711 Add POTS to Sous #89

Open
wants to merge 40 commits into
base: main
Choose a base branch
from
Open

Conversation

robert-arias
Copy link
Collaborator

@robert-arias robert-arias commented Mar 10, 2023

Issue:

Description:

  • Add project ci POTS to Sous and minimum requirements so a new build only needs to configure their ssh keys, tokens, etc on their deployment environments.

Testing:

  • Run composer install and make sure project ci POTS is installed.
  • Follow docs for pots to configure an environment on Pantheon and deploy a test project with Sous using POTS.

Notes

  • In order for Sous to fully function out of the box with Pantheon it would require committing a /web directory and composer.lock file. We decided this was not the best idea because we do not want to track these things in our repo.
  • This PR was simplified to only include what POTS expects Sous to have in order to work with Circle Ci and Pantheon.
  • We also discussed maybe the pantheon.yml gets scaffolded only if it is a Pantheon site. This PR doesn't include this functionality but does include the pantheon.yml file with settings that match Sous.
  • While we don't have lint configured out of the box; I did provide the lint composer command and added a lint.sh script file to avoid linting errors since POTS will expect something here.
  • I saw code sniffing wasn't working either so I installed the necessary packages and pointed the composer code-sniff command straight to phpcs and phpcbf without the added args and options. We can always improve on this but at least it runs now.
  • I added a phpcs.xml.dist which is expected for code-sniff. You will also notice I excluded checking emulsify.php because it fails and I didn't think we should sort that out with this PR.

@robert-arias robert-arias self-assigned this Mar 10, 2023
@robert-arias robert-arias added the 👍 Ready for Review Work is ready for review. label Mar 10, 2023
@JRuiz28 JRuiz28 self-requested a review March 10, 2023 18:40
@JRuiz28 JRuiz28 added 👁 Review in progress Under review. and removed 👍 Ready for Review Work is ready for review. labels Mar 10, 2023
@JRuiz28
Copy link
Contributor

JRuiz28 commented Mar 10, 2023

Work well for me! 👍🏾 maybe @ccjjmartin can confirm if it is what is needed

@JRuiz28 JRuiz28 added ❔ Question Further information is requested. 👍 Ready for Review Work is ready for review. 🎉 Passes Functional Review Functionality is approved by the reviewer. and removed 👁 Review in progress Under review. 👍 Ready for Review Work is ready for review. labels Mar 10, 2023
composer.json Outdated Show resolved Hide resolved
@ccjjmartin
Copy link
Collaborator

Ideally, this PR would be associated with a site on Pantheon and the Project CI setup would include the necessary files to have CircleCI running the deployment. This does assume we are going to support Pantheon out of the box though so let's discuss this in the next Sous meeting @robert-arias

@cbfannin
Copy link
Contributor

@robert-arias @ccjjmartin This PR is marked "Needs Review" on d.o

Do you know where we left off with this?

@laura-johnson
Copy link
Contributor

It would be good to get this set up to deploy to a demo site on Pantheon.

As part of this ticket, let's follow the steps here to create a sous project on Pantheon and configure this repo to deploy to it.

@cbfannin cbfannin self-assigned this Aug 9, 2023
@cbfannin cbfannin added 👉 Needs Work Reviewer has requested changes. 🚧 Work in Progress The PR is a work in progress. and removed ❔ Question Further information is requested. 🎉 Passes Functional Review Functionality is approved by the reviewer. 👉 Needs Work Reviewer has requested changes. labels Aug 9, 2023
@cbfannin
Copy link
Contributor

cbfannin commented Aug 29, 2023

@laura-johnson @ccjjmartin I set up a Pantheon site but as I started the process to migrate our repo to Pantheon I got stuck with understanding what we need to do with the web directory. Here is a thread on Slack of my confusion.

@robert-arias robert-arias removed their assignment Sep 12, 2023
@cbfannin cbfannin changed the title Add Project CI to Sous 3339711 Add Project CI to Sous Sep 22, 2023
@cbfannin cbfannin changed the title 3339711 Add Project CI to Sous 3339711 Add POTS to Sous Oct 6, 2023
@cbfannin cbfannin added 👍 Ready for Review Work is ready for review. and removed 🚧 Work in Progress The PR is a work in progress. labels Oct 6, 2023
@cbfannin cbfannin requested review from laura-johnson, ccjjmartin and randallquesadaa and removed request for JRuiz28 October 6, 2023 22:26
CHANGELOG.md Outdated

All notable changes specific to pantheon-upstreams/drupal-composer-managed are noted here.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the sous changelog overwritten with drupal-composer-managed changelog?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@laura-johnson Could it be a change from when @cbfannin merge the Pantheon repository with ours?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be! I think we want the sous version though...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@laura-johnson @randallquesadaa Original changelog restored. Does that make this ready to merge? i.e. someone has functionally tested this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👍 Ready for Review Work is ready for review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants