fix(ReportUtils): Include files with 'No_license_found' as well #2745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the changes for de-duplication of licenses with the same SPDX ID, exported reports do not contain any files with 'No_license_found'. But these have to be reported as well. Change the behaviour of addScannerResults() to include these files again. Signed-off-by: Jan Altenberg <[email protected]>
JanAltenberg
force-pushed
the
fix/reportutils-report-no_license_found
branch
from
d97fbc3
to
9bf69d4
Compare
shaheemazmalmmd
added
needs code review
needs test
ready
and removed
needs code review
needs test
labels
shaheemazmalmmd
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since the changes for de-duplication of licenses with the same SPDX ID in commit e01006b , exported reports do not contain entries for files fith 'No_license_found'. These have to be included (and were included before the above mentioned commit).
Changes
This commit adjusts the behaviour of addScannerResults() in a way, that files with 'No_license_found' will be reported.
How to test
Without these changes the reports won't contain any entries for all files with 'No_license_found' as scanner result (for busybox, Makefile.custom in the top level directory is such a file). With these changes applied, the reports will contain the relevant entries.