refactor(php):used expressions with combined operators #2685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GMishx what can i do to get this merged? |
|
@Ibrahim-Muhammad13 Please rebase the branch with master also consider changing the commit message as per https://github.com/fossology/fossology/blob/master/CHANGELOG.md |
Also prevent adding user to group using PUT request as POST request already does that. Signed-off-by: Gaurav Mishra <[email protected]>
Signed-off-by: Gaurav Mishra <[email protected]>
Signed-off-by: Gaurav Mishra <[email protected]>
Signed-off-by: dushimsam <[email protected]>
Signed-off-by: Gaurav Mishra <[email protected]>
Signed-off-by: Gaurav Mishra <[email protected]>
Fix index creation commands to match values from DB, preventing recreation of indexes.
Signed-off-by: Shaheem Azmal M MD <[email protected]>
Separate licenses with or without obligations, fix license class to get SPDXID. Signed-off-by: Shaheem Azmal M MD <[email protected]>
1. Since RDF files are XML, putting unescaped text in `<spdx:attributionText>` can cause failures. To prevent, put text in `<![CDATA[ ]]>` 2. Prevent running build-test.yml on pushes other than `master` branch. 3. Add missing keyword other highlight. 4. Update workflows to use checkout v3. Signed-off-by: Gaurav Mishra <[email protected]>
Signed-off-by: Shaheem Azmal M MD <[email protected]>
… jobs queued based on an upload
fix(API): /uploads/{id}/summary threw 500 error when returning the summary of an upload which was a file
Signed-off-by: Krishna Mahato <[email protected]>
Signed-off-by: Gaurav Mishra <[email protected]>
…Email tables Signed-off-by: Sanjay Krishna S R <[email protected]>
Signed-off-by: Sanjay Krishna S R <[email protected]>
Signed-off-by: Sanjay Krishna S R <[email protected]> Feat(invertSearch):Removed unwanted changes Signed-off-by: Sanjay Krishna S R <[email protected]> feat(invertSearch):Added inverse search in Email/Url/Author Page Signed-off-by: Sanjay Krishna S R <[email protected]> abc feat(inverseSearch):fixed alignments Signed-off-by: Sanjay Krishna S R <[email protected]>
1. Remove import of old file. 2. Fix DbHelper::getFilenameFromUploadTree() to not cache query parameter. Signed-off-by: Gaurav Mishra <[email protected]>
Signed-off-by: Krishna Mahato <[email protected]> Signed-off-by: Gaurav Mishra <[email protected]>
Signed-off-by: Gaurav Mishra <[email protected]>
Signed-off-by: Gaurav Mishra <[email protected]>
Update `composer/spdx-licenses` to latest version `1.5.8` to get latest SPDX License list version 3.22 Signed-off-by: Gaurav Mishra <[email protected]>
Signed-off-by: Gaurav Mishra <[email protected]>
Signed-off-by: Gaurav Mishra <[email protected]>
1. Fix token generation for user page. 2. Fix error handling in user-edit.php 3. Fix the path `/users/token` to be authenticated. 4. Handle `user_edit` plugin exception in UserController.php Signed-off-by: Gaurav Mishra <[email protected]>
Make the datatype of `rf_detector_type` consistent to int type from string based on `src/cli/exportLicenseRefUsingSPDX.php`. This is helpful for https://github.com/fossology/LicenseDb and anyother project trying to read this file from typed programming language like Golang. Signed-off-by: Gaurav Mishra <[email protected]>
Do not check page number 1 (which is the least value) if response list is empty. Signed-off-by: Gaurav Mishra <[email protected]>
Check if ScanOSS agent is installed before loading the data in View page. Signed-off-by: Gaurav Mishra <[email protected]>
Signed-off-by: Gaurav Mishra <[email protected]>
Signed-off-by: Shaheem Azmal M MD <[email protected]>
Signed-off-by: Gaurav Mishra <[email protected]>
…logy#2658) fix(php) : Fix null pointer issue in createClearingDecisions() Signed-off-by: Kgitman <[email protected]> Reviewed-by: [email protected]
Signed-off-by: Shaheem Azmal M MD <[email protected]>
Signed-off-by: Gaurav Mishra <[email protected]>
1. If a2ensite fails on postinstall, disable (delete) the old file first 2. Do not create files in site-enabled, rather in sites-available in `web/postinst` Signed-off-by: Gaurav Mishra <[email protected]>
Signed-off-by: Gaurav Mishra <[email protected]>
Use GroupID while fetching licenses in AjaxExplorer as OJO can create candidate licenses since fossology#1887 Signed-off-by: Gaurav Mishra <[email protected]>
Create 2 consts: 1. SPDXREF_PREFIX = "LicenseRef-" to identify any LicenseRef 2. SPDXREF_PREFIX_FOSSOLOGY = "LicenseRef-fossology-" to add FOSSology's LicenseRef prefix. Signed-off-by: Gaurav Mishra <[email protected]>
Signed-off-by: Gaurav Mishra <[email protected]>
…tation changed accordingly.
…tests, models and documentation
Signed-off-by: Gaurav Mishra <[email protected]>
Signed-off-by: Ibrahim Muhammad <[email protected]>
|
@shaheemazmalmmd i think i fixed the conflicts and passed tests but i don't know what to edit in the commit message i did it as explained in contribution guide |
|
@Ibrahim-Muhammad13 I see that you have merged instead of rebase ? because of that morethan 200 commits got added to this PR. please have a look. |
|
@Ibrahim-Muhammad13 can you please update the PR for us to merge it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Increase the usage of expressions with combined operators
this closes #2121