Skip to content

Conversation

Gagan-Ram
Copy link
Member

@Gagan-Ram Gagan-Ram commented Aug 11, 2025

Fixes: #616
Screencast from 2025-08-11 19-45-00.webm

Summary by Sourcery

Enable proper rendering of links in question text by applying the rich_text_snippet filter in both presale cart review and organizer backend templates

Enhancements:

  • Render question labels in cart review template with rich_text_snippet to preserve links
  • Load and apply rich_text_snippet filter for question text in organizer control questions view

Copy link
Contributor

sourcery-ai bot commented Aug 11, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

The PR updates event and control templates to render question texts using the rich_text_snippet filter (vs. plain text) and ensures the rich_text tag library is loaded, fixing link rendering in form reviews and organizer backend.

Class diagram for template filter usage in question rendering

classDiagram
    class Template {
        +render()
    }
    class RichTextSnippetFilter {
        +apply(text)
    }
    Template --> RichTextSnippetFilter : uses
Loading

File-Level Changes

Change Details Files
Render question headings in cart review with rich_text_snippet
  • Replaced plain question text with rich_text_snippet filter for line.questions
  • Applied rich_text_snippet filter to additional_answers question headings
src/pretix/presale/templates/pretixpresale/event/fragment_cart.html
Enable rich text rendering in control questions page
  • Loaded the rich_text template tag library
  • Replaced raw question display with rich_text_snippet filter
src/pretix/control/templates/pretixcontrol/items/questions.html

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Gagan-Ram - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Contributor

@Saksham-Sirohi Saksham-Sirohi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mariobehling
Copy link
Member

@Gagan-Ram we have mostly stopped working on this area. Please make the changes against the enext branch.

@Gagan-Ram
Copy link
Member Author

we have mostly stopped working on this area. Please make the changes against the enext branch.

Yes, I created this PR for reference so I can replicate the same changes in the enext branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In form reviews and organizer backend fix links to show actual link
3 participants