-
Notifications
You must be signed in to change notification settings - Fork 103
In form reviews and organizer backend fix links to show actual link #830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: development
Are you sure you want to change the base?
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThe PR updates event and control templates to render question texts using the rich_text_snippet filter (vs. plain text) and ensures the rich_text tag library is loaded, fixing link rendering in form reviews and organizer backend. Class diagram for template filter usage in question renderingclassDiagram
class Template {
+render()
}
class RichTextSnippetFilter {
+apply(text)
}
Template --> RichTextSnippetFilter : uses
File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Gagan-Ram - I've reviewed your changes and they look great!
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@Gagan-Ram we have mostly stopped working on this area. Please make the changes against the enext branch. |
Yes, I created this PR for reference so I can replicate the same changes in the enext branch. |
Fixes: #616
Screencast from 2025-08-11 19-45-00.webm
Summary by Sourcery
Enable proper rendering of links in question text by applying the rich_text_snippet filter in both presale cart review and organizer backend templates
Enhancements: