-
Notifications
You must be signed in to change notification settings - Fork 191
stdlib_system
: essential path functionality
#999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
wassup05
wants to merge
20
commits into
fortran-lang:master
Choose a base branch
from
wassup05:path
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 15 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
657b312
added interfaces and necessary build stuff
wassup05 f41dee4
implemented interfaces
wassup05 572ad46
example
wassup05 8a10f26
tests added
wassup05 1bd58b7
added specs
wassup05 ea71960
an edge case handled
wassup05 c561108
separated examples according to OS and functions
wassup05 272eb67
further split examples and fix some autodoc links issues due to wrong…
jalvesz 5147094
misslocation of source file
jalvesz 9e64094
fix example program names
jalvesz ca867f8
fix example_path_join.f90
wassup05 62bef00
Consistent naming
wassup05 1c87df9
windows test case for path with spaces
wassup05 45824b5
remove pre-processor parameters
wassup05 3501bc9
Merge branch 'master' of github.com:wassup05/stdlib into path
wassup05 ee40f44
typos and grammar
wassup05 e6add70
added new procedures to the interfaces
wassup05 616040d
implemented the new procedures
wassup05 812b5ed
modified the docs to add `type(string_type)` arguments
wassup05 a21a48b
`assignment(=)` => `move`
wassup05 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
! Usage of base_name | ||
program example_path_base_name | ||
use stdlib_system, only: base_name, OS_TYPE, OS_WINDOWS | ||
character(len=:), allocatable :: p1 | ||
|
||
if(OS_TYPE() == OS_WINDOWS) then | ||
p1 = 'C:\Users' | ||
else | ||
p1 = '/home' | ||
endif | ||
|
||
print *, 'base name of '// p1 // ' -> ' // base_name(p1) | ||
! base name of C:\Users -> Users | ||
! OR | ||
! base name of /home -> home | ||
end program example_path_base_name |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
! Usage of dir_name | ||
program example_path_dir_name | ||
use stdlib_system, only: dir_name, OS_TYPE, OS_WINDOWS | ||
character(len=:), allocatable :: p1, head, tail | ||
|
||
if(OS_TYPE() == OS_WINDOWS) then | ||
p1 = 'C:\Users' ! C:\Users | ||
else | ||
p1 = '/home' ! /home | ||
endif | ||
|
||
print *, 'dir_name of '// p1 // ' -> ' // dir_name(p1) | ||
! dir_name of C:\Users -> C:\ | ||
! OR | ||
! dir_name of /home -> / | ||
end program example_path_dir_name |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
! Usage of join_path, operator(/) | ||
program example_path_join | ||
use stdlib_system, only: join_path, operator(/), OS_TYPE, OS_WINDOWS | ||
character(len=:), allocatable :: p1, p2, p3 | ||
character(len=20) :: parr(4) | ||
|
||
if(OS_TYPE() == OS_WINDOWS) then | ||
p1 = 'C:'/'Users'/'User1'/'Desktop' | ||
p2 = join_path('C:\Users\User1', 'Desktop') | ||
parr = [character(len=20) :: 'C:', 'Users', 'User1', 'Desktop'] | ||
p3 = join_path(parr) | ||
else | ||
p1 = ''/'home'/'User1'/'Desktop' | ||
p2 = join_path('/home/User1', 'Desktop') | ||
parr = [character(len=20) :: '', 'home', 'User1', 'Desktop'] | ||
p3 = join_path(parr) | ||
end if | ||
|
||
! (p1 == p2 == p3) = '/home/User1/Desktop' OR 'C:\Users\User1\Desktop' | ||
print *, p1 ! /home/User1/Desktop OR 'C:\Users\User1\Desktop' | ||
print *, "p1 == p2: ", p1 == p2 ! T | ||
print *, "p2 == p3: ", p2 == p3 ! T | ||
end program example_path_join |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
! Usage of split_path | ||
program example_path_split_path | ||
use stdlib_system, only: join_path, split_path, OS_TYPE, OS_WINDOWS | ||
character(len=:), allocatable :: p1, head, tail | ||
|
||
if(OS_TYPE() == OS_WINDOWS) then | ||
p1 = join_path('C:\Users\User1', 'Desktop') ! C:\Users\User1\Desktop | ||
else | ||
p1 = join_path('/home/User1', 'Desktop') ! /home/User1/Desktop | ||
endif | ||
|
||
call split_path(p1, head, tail) | ||
! head = /home/User1 OR C:\Users\User1, tail = Desktop | ||
print *, p1 // " -> " // head // " + " // tail | ||
! C:\Users\User1\Desktop -> C:\Users\User1 + Desktop | ||
! OR | ||
! /home/User1/Desktop -> /home/User1 + Desktop | ||
|
||
call split_path(head, p1, tail) | ||
! p1 = /home OR C:\Users, tail = User1 | ||
print *, head // " -> " // p1 // " + " // tail | ||
! C:\Users\User1 -> C:\Users + User1 | ||
! OR | ||
! /home/User1 -> /home + User1 | ||
end program example_path_split_path |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because stdlib offers a string type, it would be nice if these string manipulation functions were
interfaces
working with either character strings (as currently proposed), or the internalstring_type
type.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made these functions interfaces keeping this possibility in mind... But what is considered a good way of doing this? Writing procedures for
string_type
and then, when calling them withcharacter
variables just assign these to the newstring_type
variables and call thestring_type
version of the interface itself or code duplication, keeping the code separate for these two although they are in essence the same?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I got it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes: the easiest option is to keep the
character
implementation and then return the result to a string viamove
:stdlib/src/stdlib_string_type.fypp
Lines 220 to 227 in d8a90aa
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added the relevant changes... But it doesn't use
move
, it usesassignment(=)
andchar
, Let me know what you think of it.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works @wassup05, however, there are two copies:
string->char
for the input arguments, and thenchar -> string
on the assignment. Usingmove
would at least avoid incurring the last copy. Just do:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because the internal
string_type
representation is just an allocatable character variable, I would also support (to be discussed with the community as a separate PR) the implementation of a tiny zero-copy "view" function for the string type, see here: