-
Notifications
You must be signed in to change notification settings - Fork 216
Modularization of remaining modules #1100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1100 +/- ##
=======================================
Coverage 68.55% 68.55%
=======================================
Files 396 396
Lines 12746 12746
Branches 1376 1376
=======================================
Hits 8738 8738
Misses 4008 4008 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Should we try to merge this PR before releasing |
Co-authored-by: Copilot <[email protected]>
|
in the previous PR you introduced a cmake function |
No, it is not available from |
After a quick look, this approach for |
|
I see, I thought it might be useful for maintenance purpose but it is not a must. |
|
Thank you. I will merge this PR, as it implemtents only changes to the build system, with the default behaviour being unchanged. |
The CI for testing the modularization of stdlib must be divided in several workflows as the number of workflows increase exponentially with the number of modules.