Clear timers and event listeners before component unmounts #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
samueleiche
reviewed
Feb 5, 2024
docs/src/components/Navigation.vue
Outdated
| @@ -25,8 +27,18 @@ if (typeof window !== "undefined") { | |||
| clearTimeout(resizeTimer) | |||
| window.addEventListener("resize", () => { | |||
| resizeTimer = setTimeout(applySizing, 200) | |||
|
|
|||
| this.$once('hook:beforeUnmount', () => { | |||
There was a problem hiding this comment.
$once is removed in Vue 3.
:hook event prefix has also been replaced with vnode-
There was a problem hiding this comment.
Apologies for the delayed response. Somehow I missed the notification for this. Updated now :)
Arooba-git
force-pushed
the
fix-memory-leak
branch
from
d00337a
to
1fd0e52
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi 👋
Thank you for this handy utility!
We found there was an event listener and a bunch of timing events that were not cleaned up on component destruction, which led to their accumulation over time, causing memory leaks. This PR clears them just before the component unmounts. You can see the difference in the count of memory leaks as detected by Memlab.
Before
After
