Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed null value deprecation #613

Merged
merged 3 commits into from
Jan 24, 2024
Merged

Fixed null value deprecation #613

merged 3 commits into from
Jan 24, 2024

Conversation

pincombe
Copy link
Contributor

Minor change to fix depreciation warning on a null string

@stayallive
Copy link
Contributor

Wouldn't it make more sense to check for $value === null and return an empty string directly? I'm sure htmlentities is smart about it but calling it with an empty string seems a bit odd. WDYT?

@pincombe
Copy link
Contributor Author

I'm more than happy switch it over to an if statement instead however the use of ?? '' seems to be the standard way that other projects within laravel are dealing with the PHP change.

I've included a link below to a search within the laravel framework for ?? ''
https://github.com/search?q=org%3Alaravel+%3F%3F+%27%27&type=code

@pincombe
Copy link
Contributor Author

Just to let you know i've updated to function to match your requested changes.

@stayallive stayallive changed the base branch from master to 4.x January 24, 2024 10:17
@stayallive stayallive changed the base branch from 4.x to master January 24, 2024 10:20
Copy link
Contributor

@stayallive stayallive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@stayallive stayallive merged commit c9f7e78 into formers:master Jan 24, 2024
12 checks passed
stayallive added a commit that referenced this pull request Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants