Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: redirectUrl url parameter to allow dynamic redirects #2635

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Dhruwang
Copy link
Contributor

What does this PR do?

Fixes https://github.com/formbricks/internal/issues/186

How should this be tested?

Append redirectUrl param to survey link

Screenshot 2024-05-16 at 12 27 34 PM

Check docs

Screenshot 2024-05-16 at 12 45 40 PM

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read How we Code at Formbricks
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues
  • First PR at Formbricks? Please sign the CLA! Without it we wont be able to merge it 🙏

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Formbricks Docs if changes were necessary

Copy link

vercel bot commented May 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
formbricks-cloud ⬜️ Ignored (Inspect) Visit Preview Jun 3, 2024 1:03pm
formbricks-docs ⬜️ Ignored (Inspect) Visit Preview Jun 3, 2024 1:03pm

Copy link
Contributor

github-actions bot commented May 16, 2024

Thank you for following the naming conventions for pull request titles! 🙏

Copy link
Contributor

@pandeymangg pandeymangg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants