fix: formbricks init error #2633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
|
Thank you for following the naming conventions for pull request titles! 🙏 |
mattinannt
reviewed
May 16, 2024
There was a problem hiding this comment.
@pandeymangg thanks for the PR :-) A few small suggestions that came up while going through the code:
packages/js/src/website.ts
Outdated
| console.error("🧱 Formbricks - Global error: You need to pass the apiHost as the first argument"); | ||
| if (prop === "init") { | ||
| // if still initializing, return | ||
| if (isInitializing) { |
There was a problem hiding this comment.
The js-core in this case also throws a warning that it's already initialized. I think I would like to keep this and let js-core handle this case.
So we decide the cases different on the top level here:
- if !initialized
- if initializing
- add to queue
- else:
- it's an init call -> initialize + process queue
- else: error "call init first"
- if initializing
- else:
- add to queue + process queue
packages/js/src/website.ts
Outdated
| console.error( | ||
| `🧱 Formbricks - Global error: Formbricks Website SDK does not support method ${String(prop)}` | ||
| ); | ||
| return; | ||
| } | ||
|
|
||
| try { | ||
| return (window.formbricks[prop as FormbricksWebsiteMethods] as Function)(...args); | ||
| return ((window.formbricks as TFormbricksWebsite)[prop as FormbricksWebsiteMethods] as Function)( |
There was a problem hiding this comment.
shouldn't we also add this to the queue here to avoid that commands are executed in the wrong order?
(e.g. newer request after init before requests that were queued first)
mattinannt
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes formbricks/internal#184 #2671 by awaiting the promise from the init function to fulfil before calling any other function.
How should this be tested?
Checklist
Required
pnpm buildconsole.logsgit pull origin mainAppreciated