Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project cleanup #150

Merged
merged 15 commits into from
Sep 30, 2024
Merged

Project cleanup #150

merged 15 commits into from
Sep 30, 2024

Conversation

AlemTuzlak
Copy link
Contributor

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

If this is a new feature please add a description of what was added and why below:

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Unit tests

Checklist:

  • My code follows the guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings or errors
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link

github-actions bot commented Sep 27, 2024

Coverage Report

Status Category Percentage Covered / Total
🟢 Lines 86.44% (🎯 80%) 708 / 819
🟢 Statements 86.44% (🎯 80%) 708 / 819
🟢 Functions 71.87% (🎯 70%) 23 / 32
🟢 Branches 83.33% (🎯 75%) 75 / 90
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/client/context/RDTContext.tsx 96.06% 66.66% 85.71% 96.06% 49-50, 52-54
src/client/context/rdtReducer.ts 96.54% 87.5% 100% 96.54% 319-322, 324-327, 329-332, 348-351
src/client/hooks/detached/useRemoveBody.ts 55% 66.66% 100% 55% 10-18
src/client/utils/common.ts 44.44% 50% 50% 44.44% 2-4, 8-9
src/client/utils/detached.ts 100% 100% 100% 100%
src/client/utils/routing.ts 58.75% 100% 50% 58.75% 40-48, 55-68, 71-80
src/client/utils/sanitize.ts 52.43% 90.9% 33.33% 52.43% 24-35, 42-43, 54-74, 77-78, 81-82
src/client/utils/storage.ts 85.18% 75% 100% 85.18% 6-7, 14-15
Generated in workflow #11

Copy link

pkg-pr-new bot commented Sep 28, 2024

Open in Stackblitz

yarn add https://pkg.pr.new/forge42dev/Remix-Dev-Tools/[email protected]

commit: fc47ad2

Copy link
Contributor Author

@AlemTuzlak AlemTuzlak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlemTuzlak AlemTuzlak merged commit 42d4c50 into main Sep 30, 2024
6 checks passed
@AlemTuzlak AlemTuzlak deleted the project-cleanup branch September 30, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant