Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignore expired orgs #5729

Open
wants to merge 11 commits into
base: develop
Choose a base branch
from
Open

Conversation

CristiCanizales
Copy link
Contributor

@CristiCanizales CristiCanizales commented Aug 20, 2024

What does this PR do?

  • Fixes list of connected orgs to not show expired/deleted orgs

What issues does this PR fix or reference?

@W-16501566@, #1437

Functionality Before

  • Expired/Deleted orgs listed in the org picker dropdown

Functionality After

  • Expired/Deleted orgs not listed in the org picker dropdown

@CristiCanizales CristiCanizales self-assigned this Aug 20, 2024
@CristiCanizales CristiCanizales marked this pull request as ready for review August 22, 2024 00:39
@CristiCanizales CristiCanizales requested a review from a team as a code owner August 22, 2024 00:39
@CristiCanizales CristiCanizales linked an issue Aug 22, 2024 that may be closed by this pull request
@CristiCanizales CristiCanizales requested review from peternhale, mingxuanzhangsfdx and daphne-sfdc and removed request for jonifazo August 22, 2024 00:42
Copy link
Contributor

@daphne-sfdc daphne-sfdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! 🎉

Before:
Screenshot 2024-08-22 at 3 18 16 PM

After:
Screenshot 2024-08-22 at 3 11 49 PM

All the expired orgs are no longer displayed ✅

Copy link
Contributor

@peternhale peternhale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit suggestion

packages/salesforcedx-vscode-core/src/orgPicker/orgList.ts Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't List Expired Orgs in the Org Picker
4 participants