Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add E4D to the expanded pack #5607

Merged
merged 4 commits into from
May 23, 2024

Conversation

gbockus-sf
Copy link
Contributor

@gbockus-sf gbockus-sf commented May 20, 2024

What does this PR do?

  • Add E4D to the expanded pack
  • Update the expanded pack ReadME to include E4D Handled by DocWriter PR

What issues does this PR fix or reference?

@W-15734847@

Functionality Before

No E4D in expanded pack

Functionality After

E4D expanding our horizons

Testing Notes

  • Verify from clean install (no SFVCE installed) installing the expanded pack gets everything activated including E4D
  • Update from an install expanded pack -> EP w/ E4D vsix and verify everything loads successfully.
  • Install both the standard and expanded pack w/ E4D and ensure everything starts up (like 1/2 our users run this way 馃し)
  • Uninstall expanded pack and verify E4D gets uninstalled.

@@ -55,6 +55,8 @@ The Salesforce Extension Pack extension installs these extensions.
This extension (`salesforcedx-vscode-visualforce`) supports Visualforce pages and components. It uses the Visualforce Language Server and the HTML language server from VS Code.
- [Salesforce Lightning Design System (SLDS) Validator](https://marketplace.visualstudio.com/items?itemName=salesforce.salesforce-vscode-slds)
This extension (`salesforcedx-vscode-slds`) simplifies working with the Salesforce Lightning Design System (SLDS). It provides code completion, syntax highlighting and validation with recommended tokens and utility classes.
- [Einstein for Developers (Beta)](https://marketplace.visualstudio.com/items?itemName=salesforce.salesforcedx-einstein-gpt)
Use this extension (`salesforcedx-einstein-gpt`), an AI-powered developer tool, to enhance developer productivity.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AnanyaJha @sbudhirajadoc E4D specific README update for expanded pack.

@randi274
Copy link
Contributor

I've started the QE doc here, and plan to be on point for this one. I can handle QE for both teams, or at least be the E4D rep 馃

@randi274 randi274 self-requested a review May 23, 2024 19:30
Copy link
Contributor

@randi274 randi274 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Simple change with a big impact 馃憦

@gbockus-sf gbockus-sf marked this pull request as ready for review May 23, 2024 23:10
@gbockus-sf gbockus-sf requested a review from a team as a code owner May 23, 2024 23:10
@gbockus-sf gbockus-sf merged commit 9170494 into develop May 23, 2024
12 checks passed
@gbockus-sf gbockus-sf deleted the gbockus/W-15734847-add-E4D-to-Expanded-pack branch May 23, 2024 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants