Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: expanded pack related updates #5596

Merged
merged 42 commits into from
May 24, 2024
Merged

docs: expanded pack related updates #5596

merged 42 commits into from
May 24, 2024

Conversation

sbudhirajadoc
Copy link
Contributor

information about expanded pack and code builder related updates.

What does this PR do?

Update set up topic to reflect moving e4d to expanded pack and its consequences.

What issues does this PR fix or reference?

@W-15735348@

Functionality Before

e4d not in expanded pack

Functionality After

e4d now in expanded pack

information about expanded pack and code builder related updates.
@sbudhirajadoc sbudhirajadoc requested a review from a team as a code owner May 14, 2024 19:34
Copy link
Collaborator

@mleonardsfdc mleonardsfdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a suggested change for a couple of typos. LGTM!

docs/_articles/en/einstein/einstein-setup.md Outdated Show resolved Hide resolved
sbudhirajadoc and others added 4 commits May 14, 2024 15:58
fixed the setup to say only expanded pack, not extension pack.
Update README for Expanded pack.
@sbudhirajadoc sbudhirajadoc requested a review from a team as a code owner May 15, 2024 23:25
Copy link
Contributor

@randi274 randi274 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but we may want to get product review on this as well. The "why" of these changes is a little unclear, and I would be confused by it as a developer.

Randi's feedback on links.
Copy link
Contributor

@randi274 randi274 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I misread the setup section and have a revision note for you!

@sbudhirajadoc sbudhirajadoc requested review from randi274 and removed request for randi274 May 21, 2024 17:50
Update based on Randi's engineering updates.
changes in engineering workflow.
@sbudhirajadoc
Copy link
Contributor Author

updated again per request from @randi274

Copy link
Contributor

@randi274 randi274 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for going through this one so carefully with me!

CLI telemetry instructions.
@sbudhirajadoc sbudhirajadoc merged commit 5d5d330 into develop May 24, 2024
12 checks passed
@sbudhirajadoc sbudhirajadoc deleted the sonal/addtoextpack branch May 24, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants