Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: strings in lua reload #1439

Merged
merged 1 commit into from May 12, 2024
Merged

fix: strings in lua reload #1439

merged 1 commit into from May 12, 2024

Conversation

tris203
Copy link
Contributor

@tris203 tris203 commented May 10, 2024

opts.plugin can be a list of strings, but currently it would error on not being able to contact the name field

This allows providing a list of strings

@tris203
Copy link
Contributor Author

tris203 commented May 10, 2024

At the moment this doesnt handle somebody passing an invalid plugin name particularly well. But I think given that this is an experimental API and the if you are using it you probably should at least have some idea of what you are trying to do. It might be okay.

Perhaps the correct fix is to just pass the opts straight through and put the notification in the reload function below which already handles this case.

Happy to hear peoples thoughts?

@folke folke merged commit 2fcbcaf into folke:main May 12, 2024
@folke
Copy link
Owner

folke commented May 12, 2024

lgtm, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants