feat: add Georgian translation #272
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also, make sure to run |
|
Made both changes, also ran both commands, both seems to be satisfied |
fmaclen
requested changes
Feb 26, 2025
src/i18n/ka/index.ts
Outdated
| @@ -0,0 +1,163 @@ | |||
| import type { BaseTranslation } from '../i18n-types'; | |||
|
|
|||
| const en = { | |||
There was a problem hiding this comment.
Should be const ka. Also update the default export below.
Comment on lines
+131
to
+135
| test.describe('Georgian', () => { | ||
| test.use({ locale: 'ka-GE' }); | ||
| test('default language is Georgian', async ({ page }) => { | ||
| await page.goto('/settings'); | ||
| expect(await page.evaluate(() => navigator.language)).toBe('ka-GE'); |
There was a problem hiding this comment.
This test is not passing, I'm guessing it's related to the ISO code for the language but I'm not sure.
Can you double check?
There was a problem hiding this comment.
ISO code for Georgian is ka-GE.
tests/locales.test.ts
Outdated
| await page.evaluate(() => window.localStorage.clear()); | ||
| await page.reload(); | ||
| await expect(page.getByText('Servers')).not.toBeVisible(); | ||
| await expect(page.getByText('Serveurs')).toBeVisible(); |
There was a problem hiding this comment.
This assertion is in French, should be in Georgian.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.