Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Arabic translation #270

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

aldoyh
Copy link

@aldoyh aldoyh commented Feb 18, 2025

Hello there,

Just wanted to make it easier for other natives to interact with your amazing interface.

All the best.

Copy link
Owner

@fmaclen fmaclen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this translation.
There are a few changes we need to make before rolling this out.

You are also missing a test, use this example from a recent French translation we added as a reference.

@fmaclen fmaclen changed the title Arabic Translation for the Arab World feat: add Arabic translation Feb 22, 2025
@fmaclen
Copy link
Owner

fmaclen commented Feb 22, 2025

Also, make sure to run npm run format and then npm run lint to make sure the linter requirements are satisfied.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants