Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add .nvmrc to allow users to deploy on cloudflare pages #269

Merged
merged 2 commits into from
Feb 22, 2025

Conversation

sainnhe
Copy link
Contributor

@sainnhe sainnhe commented Feb 16, 2025

This project can be hosted on cf pages, as the code in gh actions. The problem is that the node version used in cf pages is not 20 which will cause the deployment failing.

This PR adds a .nvmrc that specifies node version to 20, so cf pages can be successfully deployed.

To deploy it:

  1. Fork this repo
  2. In cf pages, create a new project from forked repo
  3. Choose framework "SvelteKit"
  4. Click deploy

@fmaclen fmaclen changed the title Add .nvmrc to allow users to deploy on cloudflare pages fix: Add .nvmrc to allow users to deploy on cloudflare pages Feb 22, 2025
@fmaclen
Copy link
Owner

fmaclen commented Feb 22, 2025

We are currently deploying with an environment variable NODE_VERSION=22.12.0.
In other projects I used .node-version instead of .nvmrc, but we'll see if this works.

@fmaclen fmaclen merged commit e18b6f3 into fmaclen:main Feb 22, 2025
2 checks passed
@fmaclen
Copy link
Owner

fmaclen commented Feb 22, 2025

🎉 This PR is included in version 0.26.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@fmaclen
Copy link
Owner

fmaclen commented Feb 22, 2025

Looks like it worked, thanks for the contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants