-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
don't transform bound inputs to list for remote entities #3168
Conversation
Signed-off-by: Paul Dittamo <[email protected]>
Code Review Agent Run Status
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3168 +/- ##
==========================================
+ Coverage 76.58% 79.32% +2.73%
==========================================
Files 212 339 +127
Lines 22034 28031 +5997
Branches 2864 2877 +13
==========================================
+ Hits 16875 22235 +5360
- Misses 4367 5000 +633
- Partials 792 796 +4 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Paul Dittamo <[email protected]>
Code Review Agent Run #a0b6e8Actionable Suggestions - 1
Review Details
|
Changelist by BitoThis pull request implements the following key changes.
|
ref: https://linear.app/unionai/issue/BB-2662/update-sdk-to-support-bound-inputs-for-mapping-over-launch-plans
Why are the changes needed?
cleaning up adding support for bound inputs for mapping over remote launch plans. Works E2E without this change but figured we should still clean this up
What changes were proposed in this pull request?
don't transform bound inputs to list
How was this patch tested?
added unit test
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link
Summary by Bito
This PR enhances the transform_interface_to_list function to accept a bound_inputs parameter, preventing fixed inputs from being transformed into lists. The changes include modifications to core interface logic, documentation updates, and adjustments to remote execution handling to maintain scalar inputs.Unit tests added: True
Estimated effort to review (1-5, lower is better): 1