Skip problematic pyyaml versions #1752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: eduardo apolinario <[email protected]>
eapolinario
requested review from
wild-endeavor,
kumare3,
pingsutw and
cosmicBboy
as code owners
2 tasks
Signed-off-by: eduardo apolinario <[email protected]>
Signed-off-by: eduardo apolinario <[email protected]>
pingsutw
approved these changes
Jul 19, 2023
|
Shall we backport this to 1.8.x? |
honnix
pushed a commit
to honnix/flytekit
that referenced
this pull request
Aug 1, 2023
* Skip problematic pyyaml versions Signed-off-by: eduardo apolinario <[email protected]> * Regenerate doc-requirements Signed-off-by: eduardo apolinario <[email protected]> * Linting Signed-off-by: eduardo apolinario <[email protected]> --------- Signed-off-by: eduardo apolinario <[email protected]> Co-authored-by: eduardo apolinario <[email protected]>
honnix
added a commit
that referenced
this pull request
Aug 3, 2023
* Skip problematic pyyaml versions (#1752) * Skip problematic pyyaml versions Signed-off-by: eduardo apolinario <[email protected]> * Regenerate doc-requirements Signed-off-by: eduardo apolinario <[email protected]> * Linting Signed-off-by: eduardo apolinario <[email protected]> --------- Signed-off-by: eduardo apolinario <[email protected]> Co-authored-by: eduardo apolinario <[email protected]> * Remove dependency on responses (#1762) Signed-off-by: Hongxin Liang <[email protected]> --------- Signed-off-by: eduardo apolinario <[email protected]> Signed-off-by: Hongxin Liang <[email protected]> Co-authored-by: Eduardo Apolinario <[email protected]> Co-authored-by: eduardo apolinario <[email protected]>
fg91
pushed a commit
that referenced
this pull request
Aug 15, 2023
* Skip problematic pyyaml versions Signed-off-by: eduardo apolinario <[email protected]> * Regenerate doc-requirements Signed-off-by: eduardo apolinario <[email protected]> * Linting Signed-off-by: eduardo apolinario <[email protected]> --------- Signed-off-by: eduardo apolinario <[email protected]> Co-authored-by: eduardo apolinario <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
cython 3.0 broke a bunch of projects, including pyyaml (which is a hard dependency of flytekit)
Type
Are all requirements met?
Complete description
#1746 was overly cautious and only really worked for the combination of architecture+python versions we are running in CI. The root cause is detailed yaml/pyyaml#601 and it revolves around a mishap involving Cython+pyyaml. This PR proposes a more sane fix.
Tracking Issue
https://github.com/flyteorg/flyte/issues/
Follow-up issue
NA
OR
https://github.com/flyteorg/flyte/issues/