Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix build_docker.sh files for flag issue: -a vs -p #45

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

marvin-better
Copy link

Issue

The 3 existing (identical) docker_build.sh files all had help text describing both an -a and a -p flag for setting the project name, but only a -a was allowed.

Fix

This will allow either -a or -p to set the project name, to be compatible with existing uses and the help text.
Note that I did omit the -a from the help text: it now only prints the -p option.

Copy link

welcome bot commented Dec 19, 2023

Thank you for opening this pull request! 🙌
These tips will help get your PR across the finish line: - Most of the repos have a PR template; if not, fill it out to the best of your knowledge. - Sign off your commits (Reference: DCO Guide).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant