Add support for library search paths, external variables to jsonnet #1932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
bbatsov
reviewed
Feb 4, 2024
| "A list of directories to use as jsonnet library search paths." | ||
| :type '(repeat (directory :tag "Library search path")) | ||
| :safe #'flycheck-string-list-p | ||
| :package-version '(flycheck . "32")) |
bbatsov
reviewed
Feb 4, 2024
| assigned to the variable `var'." | ||
| :type '(repeat (directory :tag "var=file")) | ||
| :safe #'flycheck-string-list-p | ||
| :package-version '(flycheck . "32")) |
|
I'm fine with the change, but before we can merge this we need also the following:
|
|
@runejuhl Ping :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two new options to the jsonnet checker, one for setting library search paths and one for setting external code files.
I was unable to get the integration tests to run (described in https://www.flycheck.org/en/latest/contributor/contributing.html), but have tested the changes locally.