add 2 new customizable variables for tcl-nagelfar checker #1906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalisv
commented
Sep 21, 2021
michalisv
commented
- flycheck-tcl-nagelfar-headers: allow definition of pre-created header files in order to support work on large projects where functions are spread over different files/directories and nagelfar might give false-positive "unknown command" errors
- flycheck-tcl-nagelfar-args: allow definition of additional arguments for nagelfire e.g. -Wunusedvar etc
1) flycheck-tcl-nagelfar-headers: allow definition of pre-created header files in order to support work on large projects where functions are spread over different files/directories and nagelfar might give false-positive "unknown command" errors 2) flycheck-tcl-nagelfar-args: allow definition of additional arguments for nagelfire e.g. -Wunusedvar etc
|
i had some problems with the previous PR & couldn't get the CLA signing to complete. Hopefully it is ok now. |
|
The changes look good, but your branch has to be rebased on top of the current |
bbatsov
reviewed
Feb 24, 2024
| @@ -12056,11 +12056,33 @@ See URL | |||
|
|
|||
| (flycheck-def-config-file-var flycheck-chktexrc tex-chktex ".chktexrc") | |||
|
|
|||
| (flycheck-def-args-var flycheck-tcl-nagelfar-args tcl-nagelfar | |||
| :package-version '(flycheck . "0.32")) | |||
bbatsov
reviewed
Feb 24, 2024
| paths are relative to the file being checked." | ||
| :type '(repeat (file :tag "Include file")) | ||
| :safe #'flycheck-string-list-p | ||
| :package-version '(flycheck . "0.32")) |
|
Please add a changelog entry as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.