Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flycheck-error-level-interesting-p #1870

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix flycheck-error-level-interesting-p #1870

wants to merge 1 commit into from

Commits on Mar 29, 2021

  1. Fix flycheck-error-level-interesting-p 

    According to its docstring, `flycheck-error-level-interesting-p` should
return true if there are no errors as _or more severe than_
`flycheck-navigation-minimum-level`. Currently, however, it only checks
if there are any errors exactly as severe as
`flycheck-navigation-minimum-level` (via
`flycheck-has-current-errors-p`). This patch:

* improves the documentation of
  * `flycheck-has-current-errors-p`
  * `flycheck-has-errors-p`
* introduces two new functions
  * `flycheck-has-current-errors-atleast-p`
  * `flycheck-has-errors-atleast-p`
* Changes `flycheck-error-level-interesting-p` to use
  `flycheck-has-current-errors-atleast-p`, instead of its "exact"
  sibling, bringing its actual behavior in line with its documented
  behavior
    @KevOrr
    KevOrr committed Mar 29, 2021
    Configuration menu
    Copy the full SHA
    c312490 View commit details
    Browse the repository at this point in the history