Add bashate support #1866
Open
Add bashate support #1866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
pikrzysztof
force-pushed
the
kris--bashate
branch
from
11a6173
to
6f6ed3a
Compare
|
Hello, can I have some help here? |
|
@cpitclaudel Can you please help me here? |
berquist
approved these changes
Dec 9, 2022
| flycheck-option-comma-separated-list) | ||
| source) | ||
| :error-patterns | ||
| ; bash8 follows pycodestyle/pep8 default output format |
There was a problem hiding this comment.
The most minor of nits: indent and use ;; for consistency with the rest of the file.
| :error-patterns | ||
| ; bash8 follows pycodestyle/pep8 default output format | ||
| ; https://github.com/PyCQA/pycodestyle/blob/master/pycodestyle.py#L108 | ||
| ((error line-start (file-name) ":" line ":1: " (message) line-end)) |
There was a problem hiding this comment.
I thought this was weird, but lo and behold, there it is:
$ rg -F ':1:'
bashate/bashate.py
300: print("%(filename)s:%(filelineno)s:1: %(error)s" %
| source) | ||
| :error-patterns | ||
| ; bash8 follows pycodestyle/pep8 default output format | ||
| ; https://github.com/PyCQA/pycodestyle/blob/master/pycodestyle.py#L108 |
There was a problem hiding this comment.
This link is out of date. Can you update it and use a link with a fixed hash? You can press y once you've selected the line in the file on GitHub and the URL will magically change.
| See URL `https://docs.openstack.org/bashate/latest/'." | ||
| :command ("bashate" | ||
| (option "--ignore" flycheck-bashate-excluded-warnings list | ||
| flycheck-option-comma-separated-list) |
There was a problem hiding this comment.
What are your thoughts on adding max line length?
--max-line-length MAX_LINE_LENGTH
Max line length
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1865
Please have a closer look at this code. I've got next to none elisp experience.