Add syntax checker for Ansible

[PrimaryCanary]

---

name: New checker
about: Provide a new checker implementation
title: 'Add syntax checker for Ansible'
labels: 'component: checkers'
assignees: ''

---

Checklist

• I have read the Contributor's guide.
• I have documented this checker in the manual.
• I have added a test for this checker in flycheck-test.el.
• (If you have written a test) I have created a companion PR to add the
  checker tool in flycheck/docker-tools.
• I have mentioned the checker in the Changelog.

Description

Ansible YAML checker using ansible-lint.

Additional context

Fixes k1LoW/emacs-ansible#29

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

---

Sifus seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[fmdkdd]

Thanks, nice PR with tests. Good work.

I've left a minor comment, please take a look.

And sorry for the delay.

[nixfu]

It would be VERY nice if this could get completed and merged. I would love to use it.

[fredericgiquel]

What is lacking for this request to be merged ?

In this branch https://github.com/fredericgiquel/flycheck/tree/ansible-lint5, I added some commits after commit accffc6 in order to :

• fix the ansible-mode detection problem
• add support to last version of ansible-lint

Can these changes be incorporated into this PR or should I create a new one ?

[rassie]

@fmdkdd can you help unblock this PR? It seems we are missing a user who is supposed to sign a CLA and the "Changes requested" seems to be blocked too even though they have been addressed.

[rassie]

:enabled is still a predicate and needs a lambda(), like it was before it has been changed to bound-and-true-p.

[rassie]

Obsoleted by @fredericgiquel's branch.

[rassie]

I can confirm that @fredericgiquel's branch works as expected with ansible-lint v6.

[fredericgiquel]

I signed the CLA in early January so my branch should be able to be merged if you want to.
Do I need to do something else ?

[jdelStrother]

FWIW I tweaked some more bits on top of @fredericgiquel's branch - master...jdelStrother:flycheck:ansible-lint

I was finding that it was ignoring my .ansible-lint file when linting files in subdirectories, and ansible-lint v5/v6 are extremely slow unless you pass --offline to avoid downloading requirements each time.

(Adding the --offline flag does break v4 compatibility, though. v5 was released February 2021 - maybe we should just remove the v4 compatibility?)

[notetiene]

Any updates on this? Otherwise, I might create a checker myself if it's too complicated.

[Nebucatnetzer]

Would be great if we could move this forward.

[jdelStrother]

If we're ok dropping support for ansible-lint < 5, I'll rebase & submit my branch as a new PR? (ansible-lint 5 has been out for over 2 years now)

[Nebucatnetzer]

For me this would be fine but don’t know how it would affect other users. On 27 Apr 2023, at 10:55, Jonathan del Strother ***@***.***> wrote: If we're ok dropping support for ansible-lint < 5, I'll rebase & submit my branch as a new PR? (ansible-lint 5 has been out for over 2 years now) —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: ***@***.***>