Fix running checkers on remote hosts via TRAMP.

[carrete]

In response to #1816

This patch does three things:

• Update flycheck-default-executable-find to search remote hosts when
  default-directory is a remote directory. See also the documentation for
  executable-find.

• Change uses of call-process and start-process to start-file-process
  which is the same as these two functions, but starts the process on a remote
  host when default-directory is a remote directory. See also the
  documentation for
  start-file-process.

• Passes the local part of buffer-file-name to the compile command,
  e.g. strips /ssh:10.0.0.42, since the checker is run on the remote machine
  where the file name must be local. See also the documentation for
  file-local-name.

[CLAassistant]

All committers have signed the CLA.

[carrete]

This appears to be obsolete. flycheck-find-checker-executable calls flycheck-executable-find which calls executable-find which returns an absolute path.

[carrete]

I'll do something about the Travis CI errors

[cpitclaudel]

👍 This is very exciting stuff. I'm swamped with work right now, but I should have time to look at this later this month. Hope that's OK!

[carrete]

👍 This is very exciting stuff. I'm swamped with work right now, but I should have time to look at this later this month. Hope that's OK!

Absolutely. I still have to get the tests to pass. I get different results locally 🤔

[carrete]

First of all, this only works with Emacs 27.1, the first version to include the second, optional remote option to executable-find. The advice approach is the best I could do because even when (executable-find executable t) is behind a version check byte-compilation fails.

Please see my comment about start-file-process when let bound. I think it's true, though I'm not certain.

I don't know what's up with the tests. These https://gist.github.com/carrete/8ab881bc3ff1a9c20285f9edf6ce8ac6 are my local test results for Emacs 26.3 and 27.1 which both behave the same. I couldn't get Emacs 25.3 to work.

I have no idea why flycheck-set-checker-executable/file-not-executable fails. Apparently warnings.el is seen as executable even though its file permissions say it isn't. I see a recent pull-request, https://travis-ci.org/github/flycheck/flycheck/builds/741547489, that has the same spec failure so I assume the changes in this pull-request aren't to blame. The builds on Travis CI behave differently even though I used docker-tools and the same build and test commands in .travis.yml. I don't know why the results are different.

I've been using this version in my day job the past week and haven't noticed any problems. At this point I'm not sure what I should try next. Any ideas would be greatly appreciated, @cpitclaudel. No rush. Thanks!

[carrete]

I pushed up an additional change that updates the built-in checkers. Sorry, I shouldn't have submitted the pull-request without this. I was distracted by the odd test failures and forgot about it. I still don't get the same results as on Travis CI. The tests behave better there than they do on my laptop. As for the remaining test failures on Travis CI, I believe these are because source (possibly more) needs to be tweaked somehow too before it's substituted in the checker definitions.

[Blade6570]

Hey, why not replace all executable-find to executable-find-add-remote? After I replaced it, I did not get any error.

[carrete]

@Blade6570 Do you mean tests passed? Provided I understand the issue correctly, the file name of the buffer must also be localized.

[yfyyfy]

Based on this pull request, I made further changes so that remote check works on my environment.
I also added support for eslint and stylelint.
Please see #1922 for the details.

[carrete]

I needed this recently so I took the opportunity to rebase this on top of the latest upstream, plus add the changes by @yfyyfy to fix the stylelint tests. With these and the move to GitHub Actions the tests now pass.

[peterbecich]

Can this be merged? Or #1922 ? It would help me significantly. Thank you

[carrete]

@jcs090218 I added the flycheck- prefix as requested. Please let me know if you'd like me to make any other changes. Thanks for taking the time to look this over

[peterbecich]

Thank you @carrete and @jcs090218

[peterbecich]

Any chance this can be merged?

[peterbecich]

@marsam , any chance this can be merged? Thank you

[zabuxx]

It would be great if this could be merged...