Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only install external major modes on CI when testing Emacs master #1760

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

cpitclaudel
Copy link
Member

External major modes break all the time, causing spurious failures when building pull requests. Testing major modes only on master allows us to investigate breakage while reducing spurious failures (master is allowed to fail).

@fmdkdd
Copy link
Member

fmdkdd commented May 9, 2020

Hmm, I guess that we don't strictly need the major modes for the integration tests. We just need flycheck to be on and to call the correct checker.
It seems that you needed to mock some mode-specific variables though, is that it?

@cpitclaudel
Copy link
Member Author

Hmm, I guess that we don't strictly need the major modes for the integration tests. We just need flycheck to be on and to call the correct checker.

Exactly. It's still good to test with the real thing, but at least now we do that test in a branch that's allowed to fail, so a PR for a new julia checker doesn't break because racket-mode is broken on MELPA or because xyz-mode decided to drop compatibility with Emacs < 123.4

It seems that you needed to mock some mode-specific variables though, is that it?

That's it. Which isn't too bad, because it shows that we were missing a few defvars ^^

External major modes break all the time, causing spurious failures when building
pull requests.  Testing major modes only on master allows us to investigate
breakage while reducing spurious failures (master is allowed to fail).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants