Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mpi: add tioga compiler/MPI to tests #11

Merged
merged 1 commit into from
Feb 13, 2024
Merged

Conversation

wihobbs
Copy link
Member

@wihobbs wihobbs commented Jan 24, 2024

Problem: we don't test the MPIs and compilers on Tioga.

Let's do that.

Turns out this is really easy to do, so why not go ahead and do it?

@wihobbs wihobbs requested a review from grondo January 24, 2024 00:12
@wihobbs
Copy link
Member Author

wihobbs commented Jan 24, 2024

I spoke too soon. I think we need the flux-coral2 MPICH plugin for this to work...

@wihobbs wihobbs marked this pull request as draft January 24, 2024 00:20
Problem: we don't test the MPIs and compilers on
Tioga.

Let's do that.
@wihobbs wihobbs force-pushed the tioga branch 2 times, most recently from 05dd12a to 4f99b72 Compare February 13, 2024 19:43
@wihobbs wihobbs marked this pull request as ready for review February 13, 2024 19:44
@wihobbs
Copy link
Member Author

wihobbs commented Feb 13, 2024

@grondo This is ready for a review now.

You can see the verbose output (dropped in the latest commit) here.

Copy link

@grondo grondo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 👍 🎉

@wihobbs wihobbs merged commit 584a73c into flux-framework:main Feb 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants