flux-jobs: filter against all users with --include #6646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: A number of the user filtering options for flux jobs are not tested because different users submitting jobs was not easy to test in earlier builds of flux. Today we can use job-exec's testexec to test different user job submissions. Solution: Test flux-jobs user filtering in a new test file t2800-jobs-cmd-multiuser.t.
Problem: The --include option is predominantly used for finding jobs on specific hosts. This implies that the -A option is set (i.e. filter on all user jobs) but it is currently not. This can be confusing to users wondering why --include isn't finding any jobs running on specific hosts. Solution: If the user did not specify filtering on a specific user with --user, then assume all user jobs (i.e. -A or --user=all) will be checked when --include is specified. Fixes flux-framework#6585
Problem: The --include option in flux-jobs(1) implies that -A (all user jobs) will be used. But this is not documented. Add documentation in flux-jobs(1) that -A is also assumed when --include is used.
Problem: There are no tests to cover the flux-jobs --include filtering with multiple user job submissions. Add some coverage to t2800-jobs-cmd-multiuser.t.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6646 +/- ##
==========================================
+ Coverage 83.84% 83.86% +0.01%
==========================================
Files 533 533
Lines 88330 88338 +8
==========================================
+ Hits 74064 74083 +19
+ Misses 14266 14255 -11
|
|
Had one builder fail with an error i've never seen before hmmm signal 13 is SIGPIPE. That's not good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: The --include option is predominantly used for finding jobs on specific hosts. This implies that the -A option is set (i.e.
filter on all user jobs) but it is currently not. This can be confusing to users wondering why --include isn't finding any jobs running on specific hosts.
Solution: If the user did not specify filtering on a specific user with --user, then assume all user jobs (i.e. -A or --user=all) will be checked when --include is specified.
side note, the 1 tricky part was how to tell if the user specified
--user=Xon the command line so we didn't assume "-A" when--includewas specified. I setup a new filter action that sets a argparse flag "filtereduser". There were probably other ways of doing this, but went with this approach.