Skip to content

Conversation

@rkishan516
Copy link
Contributor

Adds a go link for a new design document.

@rkishan516 rkishan516 requested review from a team, antfitch, parlough and sfshaza2 as code owners May 25, 2025 09:17
Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rkishan516, I cannot view this page.

@rkishan516
Copy link
Contributor Author

@rkishan516, I cannot view this page.

That's weird, I have got so many feedback over doc.
Link :- https://docs.google.com/document/d/1LfHjsg6-WPtpfxxKwYBCokRdN8O92AB0xDk7TUR8JmQ/edit

@sfshaza2
Copy link
Contributor

The page must be viewable in incognito mode. For example, Google employees can't create these pages from their @google.com emails, as that requires logging in. We want these pages viewable to anyone.

@sfshaza2
Copy link
Contributor

/gcbrun

@rkishan516
Copy link
Contributor Author

The page must be viewable in incognito mode. For example, Google employees can't create these pages from their @google.com emails, as that requires logging in. We want these pages viewable to anyone.

Yup, its visible for everyone. Able to open in incognito.

@flutter-website-bot
Copy link
Collaborator

Visit the preview URL for this PR (updated for commit 5713491):

https://flutter-docs-prod--pr12070-patch-1-tmmr541b.web.app

Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before, I couldn't see the page at all. Now I see this:

Screenshot 2025-05-27 at 10 13 49 AM

@rkishan516
Copy link
Contributor Author

https://docs.google.com/document/d/1LfHjsg6-WPtpfxxKwYBCokRdN8O92AB0xDk7TUR8JmQ/edit

image

I don't know, how its behaving like that for you, but above is what i can see in Incognito.

@sfshaza2
Copy link
Contributor

@rkishan516, I've confirmed with colleagues that the images in the doc aren't viewable. I suggest that you create a new doc by copying the template and then add your text there. I'm not sure what else to suggest.

@sfshaza2 sfshaza2 added the act.wait-for-customer Needs response from customer label May 28, 2025
@rkishan516
Copy link
Contributor Author

@sfshaza2 I created new doc by copying template and now, even I am not able to see images.

@sfshaza2
Copy link
Contributor

Yup, that's what I am seeing even on the earlier doc. Let me snoop around to see what I can learn...

@sfshaza2 sfshaza2 removed the act.wait-for-customer Needs response from customer label May 30, 2025
@sfshaza2
Copy link
Contributor

@rkishan516, after asking around and no one had any idea, so I filed a bug against Chrome. Stay tuned.

Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahhhh! It's working now! (I guess it just needed a weekend.) lgtm

@sfshaza2 sfshaza2 merged commit 91fe679 into flutter:main Jun 2, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants