Skip to content

[google_sign_in] Add exception info to migration guide #9574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

stuartmorgan-g
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g commented Jul 7, 2025

Adds discussion of the new exception flows to the migration guide.

Also makes the API comment discussion of initialize more thorough

Fixes flutter/flutter#171704
Fixes flutter/flutter#171746

Pre-Review Checklist

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2 3

Adds discussion of the new exception flows to the migration guide.
@stuartmorgan-g stuartmorgan-g added the override: no versioning needed Override the check requiring version bumps for most changes label Jul 7, 2025
@stuartmorgan-g

This comment was marked as outdated.

@stuartmorgan-g stuartmorgan-g removed the override: no versioning needed Override the check requiring version bumps for most changes label Jul 8, 2025
@stuartmorgan-g
Copy link
Contributor Author

I folded in another minor docs update from another issue that just came in, so that I wouldn't have to do conflict resolution to land them both since they are both simple.

Copy link
Contributor

@bparrishMines bparrishMines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[google_sign_in] initialize shouldn't be called multiple times [google_sign_in] Add discussion of exceptions to the migration guide
2 participants