Skip to content

[google_maps_flutter]: Add eea notice to the google maps flutter readme #9552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

illuminati1911
Copy link

Adds mandatory European Economic Area notice to the Google Maps Flutter README.md documentation.

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2 3

@stuartmorgan-g
Copy link
Contributor

Adds mandatory European Economic Area notice to the Google Maps Flutter README.md documentation.

Why is this mandatory? Please provide a link to the explanation of where this is required to be shown; it seems very strange to me that it would be required for the plugin, which doesn't currently display any of the other ToS, rather than just as part of signing up for the Google Maps API usage itself, where accepting ToS is already part of the process.

@caio1985
Copy link

caio1985 commented Jul 7, 2025

@stuartmorgan-g this is part of a Google Maps wide changes that happened to our product documentation and OSS libraries you can find more info on b/426012814#comment2

If users are using Google Maps through any plugins they should be aware, this is why we need the README to point to it.

@stuartmorgan-g
Copy link
Contributor

@stuartmorgan-g this is part of a Google Maps wide changes that happened to our product documentation and OSS libraries you can find more info on b/426012814#comment2

I don't see anything in that comment that answers my question. It just refers very generally to "documentation". It does not explain why this would require display at every wrapper layer when other ToS don't.

If users are using Google Maps through any plugins they should be aware, this is why we need the README to point to it.

Right, and the first step of using Google Maps through this plugin is to go to the developer console and enable the API. Why is that central place where developers enable use of the API not the place where they need to be informed of, and agree to, all ToS?

@caio1985
Copy link

caio1985 commented Jul 8, 2025

@stuartmorgan-g this is the link of the broader communication affecting Google Maps Platform: https://developers.google.com/maps/comms/eea/faq

In our organization we must add this upfront disclaimer to product documentation, OSS libraries.

@stuartmorgan-g
Copy link
Contributor

@stuartmorgan-g this is the link of the broader communication affecting Google Maps Platform: https://developers.google.com/maps/comms/eea/faq

That appears to be user-facing documentation, and is not responsive to my question.

The only thing I see that seems relevant to what I'm asking is https://developers.google.com/maps/comms/eea/faq#accept-tos which says that accepting the ToS is something that happens in the cloud console UI, which only reinforces my confusion as to why this is being added here.

As I said above, this README does not discuss any Google Maps SDK ToS, because that is handled at a different layer of the process for plugin clients. My question continues to be why this particular part of the ToS is different from all historical and current practice regarding ToS and this plugin.

In our organization we must add this upfront disclaimer to product documentation, OSS libraries.

And all I've been asking for is clear documentation of that mandate. If every piece of open source software that wraps and re-exposes the Google Maps SDK is required to "forward" this particular piece of the ToS in its own documentation, then that requirement must be publicly documented somewhere, which would answer my question. If it does not apply to everyone, but does apply to code owned by the Flutter team, then I'm sure there is someone who can explain the contours of this requirement to me so that we can properly implement them, and document the requirement to ensure that someone else doesn't just remove this out of lack of awareness the next time someone reworks this README. If that can't be done here, please feel free to have someone arrange a meeting with me internally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants