Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[camera] Skip another flaky Android test #8732

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

stuartmorgan
Copy link
Contributor

This test is showing the same flake as the recently-skipped "detached create does not call create on the Java side" tests.

See flutter/flutter#164132

This test is showing the same flake as the recently-skipped "detached create does not call create on the Java side" tests.

See flutter/flutter#164132
@stuartmorgan
Copy link
Contributor Author

Hm, I just had to re-run a different test that flaked with the same PlatformException(channel-error, Unable to establish connection on channel., null, null). Maybe this is a structural problem with the version of the proxy code it's currently using?

Copy link
Contributor

@bparrishMines bparrishMines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

The method call fails asynchronously, so its probably possible that it depends on if the machine finishes all the tests before the failure happens.

@stuartmorgan
Copy link
Contributor Author

The method call fails asynchronously, so its probably possible that it depends on if the machine finishes all the tests before the failure happens.

I may need to disable all of these tests then, because now the next test is failing all the time (maybe because it's a shorter test run)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants