[webview_flutter_wkwebview] Fixes crash where the native AuthenticationChallengeResponse could not be found for auth requests
#8707
+227
−165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bparrishMines
changed the title
AuthenticationChallengeResponse could not be found for auth requests
bparrishMines
commented
Feb 25, 2025
packages/webview_flutter/webview_flutter_wkwebview/lib/src/webkit_webview_controller.dart
Outdated
Show resolved
Hide resolved
stuartmorgan
requested changes
Feb 27, 2025
packages/webview_flutter/webview_flutter_wkwebview/pigeons/web_kit.dart
Outdated
Show resolved
Hide resolved
...flutter_wkwebview/Sources/webview_flutter_wkwebview/NavigationDelegateProxyAPIDelegate.swift
Outdated
Show resolved
Hide resolved
bparrishMines
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 28, 2025
…uthenticationChallengeResponse` could not be found for auth requests (flutter/packages#8707)
This comment was marked as resolved.
This comment was marked as resolved.
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 28, 2025
flutter/packages@01d3d5c...70b41e1 2025-02-28 [email protected] [camera_avfoundation] Migrate tests to Swift - part 3 (flutter/packages#8661) 2025-02-28 [email protected] Do not update patch versions for `dependabot/github-actions`. (flutter/packages#8697) 2025-02-28 [email protected] [flutter_plugin_android_lifecycle] use flutter.compileSdkVersion to see what breaks (flutter/packages#8700) 2025-02-28 [email protected] [webview_flutter_wkwebview] Fixes crash where the native `AuthenticationChallengeResponse` could not be found for auth requests (flutter/packages#8707) 2025-02-27 [email protected] Roll Flutter from 1659206 to 2e570ca (75 revisions) (flutter/packages#8731) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the return type of the auth callback method to a
Listinstead of anAuthenticationChallengeResponse.@ProxyApidoesn't support tuples or data classes, so this was the simplest to switch to.Fixes flutter/flutter#162437
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.