Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flutter_markdown]: Invert order of style merging #8163

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

domesticmouse
Copy link
Contributor

@domesticmouse domesticmouse commented Nov 24, 2024

Fixes: flutter/flutter#81720

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

@csells
Copy link
Contributor

csells commented Nov 27, 2024

@navaronbracke: I noticed what a great job you did on flutter/flutter#158428. would you be able to take a look at this one? the recommended fix is in place, but the new test results need to be verified and the tests updated for the new blockquote styling behavor.

@navaronbracke
Copy link
Contributor

@csells If I were to look at this PR, what would be expected of me here? The PR doesn't yet link to an issue that it fixes, so I'm unsure what the expected behavior is. Do you need me to write a test for this PR?

what a great job you did on flutter/flutter#158428

That was only a very small fix, though :p

@csells
Copy link
Contributor

csells commented Nov 27, 2024

@navaronbracke: actually, I expect this fix to be even smaller. here's the bug report: flutter/flutter#81720

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: blockquote property not being applied in MarkdownBody widget
3 participants