-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[flutter_markdown]: Invert order of style merging #8163
[flutter_markdown]: Invert order of style merging #8163
Conversation
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
@navaronbracke: I noticed what a great job you did on flutter/flutter#158428. would you be able to take a look at this one? the recommended fix is in place, but the new test results need to be verified and the tests updated for the new blockquote styling behavor. |
@csells If I were to look at this PR, what would be expected of me here? The PR doesn't yet link to an issue that it fixes, so I'm unsure what the expected behavior is. Do you need me to write a test for this PR?
That was only a very small fix, though :p |
@navaronbracke: actually, I expect this fix to be even smaller. here's the bug report: flutter/flutter#81720 |
FYI @mit-mit this is an important fix for an upcoming release |
…er_markdown-invert-order-of-style-merging
@csells, the failing unit test on this PR is flagging that this isn't a complete and proper fix. Can you please take ownership of this fix and do the required investigation in to how to properly fix this issue? |
This issue isn't blocking but yes, I'll own it ongoing. Thanks for bringing it this far, @domesticmouse |
Any updates here guys? |
on it! |
Fixes: flutter/flutter#81720
Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.